Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New S2 Layer Catalog (Experimental) #2589

Merged
merged 2 commits into from
Feb 12, 2019
Merged

New S2 Layer Catalog (Experimental) #2589

merged 2 commits into from
Feb 12, 2019

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Jan 18, 2019

For #2588

@xintongxia xintongxia mentioned this pull request Jan 30, 2019
Closed
ibgreen
ibgreen commented Jan 31, 2019
View reviewed changes
Copy link
Collaborator Author

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a couple of comments.

examples/layer-browser/package.json Outdated Show resolved Hide resolved
modules/s2-layers/src/s2-layer/s2-layer.js Outdated Show resolved Hide resolved
modules/s2-layers/src/s2-layer/s2-layer.js Show resolved Hide resolved
docs/layers/s2-layers/s2-layer.md Outdated Show resolved Hide resolved
ibgreen
ibgreen commented Feb 6, 2019
View reviewed changes
Copy link
Collaborator Author

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

docs/layers/s2-layers/s2-layer.md Show resolved Hide resolved
docs/layers/s2-layers/s2-layer.md Outdated Show resolved Hide resolved
docs/layers/s2-layers/s2-layer.md Outdated Show resolved Hide resolved
docs/layers/s2-layers/s2-layer.md Outdated Show resolved Hide resolved
Ib Green and others added 2 commits February 7, 2019 07:54
Add s2-layers catalog
d80c8cb 
Fix docs

Add s2-layers catalog

Update whats new

use the most recent API

match current deck.gl version

resolve comments
resolve comments
237c45f
@xintongxia xintongxia merged commit 0005c0e into master Feb 12, 2019
@xintongxia xintongxia deleted the ib/s2-layers branch February 12, 2019 18:46
@xintongxia xintongxia restored the ib/s2-layers branch February 13, 2019 08:05
xintongxia pushed a commit that referenced this pull request Feb 13, 2019
Revert "New S2 Layer Catalog (Experimental) (#2589)"
af0e6f4 
This reverts commit 0005c0e.
@Pessimistress Pessimistress deleted the ib/s2-layers branch February 26, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia left review comments

@Pessimistress Pessimistress Pessimistress approved these changes

@urosi2453 urosi2453 Awaiting requested review from urosi2453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibgreen @Pessimistress @xintongxia