add type for defaultProps in path outline layer #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
requested changes
Dec 19, 2018
modules/experimental-layers/src/path-outline-layer/path-outline-layer.js
Outdated
Show resolved
Hide resolved
XiaokaiUber
force-pushed
the
update-props-path-outline-layer
branch
from
45e1498 to
4f135d5
Compare
modules/experimental-layers/src/path-outline-layer/path-outline-layer.js
Outdated
Show resolved
Hide resolved
|
Test your change in the layer browser. |
XiaokaiUber
force-pushed
the
update-props-path-outline-layer
branch
from
8c908fb to
abb1fc8
Compare
XiaokaiUber
force-pushed
the
update-props-path-outline-layer
branch
from
abb1fc8 to
d4ac548
Compare
|
Did you test this layer with |
Yes. If |
modules/experimental-layers/src/path-outline-layer/path-outline-layer.js
Outdated
Show resolved
Hide resolved
XiaokaiUber
force-pushed
the
update-props-path-outline-layer
branch
from
d4ac548 to
2450c14
Compare
| @@ -2,6 +2,7 @@ import {PathLayer} from '@deck.gl/layers'; | |||
| import GL from '@luma.gl/constants'; | |||
| import {Framebuffer, Texture2D} from 'luma.gl'; | |||
| import outline from '../shaderlib/outline/outline'; | |||
| import assert from '../../../core/src/utils/assert'; | |||
There was a problem hiding this comment.
You cannot import something from another module. This is not going to be the directory structure when the module is published.
| getValue: (object, index) => getZLevel(object, index) || 0 | ||
| getValue: (object, index) => { | ||
| const zLevel = getZLevel(object, index); | ||
| assert(!isNaN(zLevel), '`getZLevel` does not return a number!'); |
There was a problem hiding this comment.
Just keep the old behavior before your change.
Pessimistress
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2477
Background
In path outline layer, the defaultProps don't have types specified. We need to specify type for those props.
Change List
note: tested with render test and layer-browser. compared the rendering result with that in 6.3-release