Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up npm scripts #1657

Merged
merged 3 commits into from
Apr 10, 2018
Merged

Clean up npm scripts #1657

merged 3 commits into from
Apr 10, 2018

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Apr 6, 2018 •
edited
Loading

Background

Clean up root scripts, remove those that are never run manually.
This allows us to add comments and formatting to complex scripts, makes them easier to maintain.

Change List

  • Collect test scripts into one.
npm run test
npm run test fast
npm run test dist
npm run test cover
npm run test ci
npm run test examples
  • Collect lint scripts into one. Automatically run prettier if prettier-check fails.

@Pessimistress Pessimistress changed the title [FOR DISCUSSION] Clean up npm scripts Clean up npm scripts Apr 9, 2018
@Pessimistress Pessimistress merged commit 732b72e into visgl:master Apr 10, 2018
@Pessimistress Pessimistress deleted the scripts branch April 10, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianhuang01 jianhuang01 jianhuang01 approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pessimistress @jianhuang01