WindDemo: Rename uniforms #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
reviewed
Jan 4, 2018
|
@ibgreen , its doing per-fragment lighting, so needed project methods in fragment shader. When we support per-fragment lighting in |
Pessimistress
approved these changes
Jan 4, 2018
ibgreen
approved these changes
Jan 5, 2018
| @@ -0,0 +1,159 @@ | |||
| // NOTE: this is same as luma.gl 'fp32' module except this is applied to fragment shader. | |||
| const fsfp32shader = `\ | |||
There was a problem hiding this comment.
Maybe no need to copy the text? Can't we just import the luma.gl module and just create a new javascript object
export default {fs: vsmodule.vs}
?
1chandu
added a commit
that referenced
this pull request
Jan 6, 2018
* WindDemo: Create and FS versions of fp32, project and lighting modules and remove duplicate shader code from layers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fp32,projectandlightingshader modules.delaunay-coverandwindlayer and use above shader modules.Verified running wind demo.