Remove deprecated API #1240
Merged
Remove deprecated API #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ibgreen
approved these changes
Dec 15, 2017
| @@ -1,6 +1,6 @@ | |||
| # Upgrade Guide | |||
|
|
|||
| ## Upgrading from deck.gl v4.1 to v4.2 | |||
| ## Upgrading from deck.gl v4.1 to v5 | |||
There was a problem hiding this comment.
+1 Did you do a global search for 4.2?
There was a problem hiding this comment.
Replaced in other places too.
docs/upgrade-guide.md
Outdated
| @@ -52,6 +52,10 @@ All our layers enable depth test so we are going set this state during initializ | |||
| For any custom needs, these parameters can be overwritten by updating them in [`onWebGLInitialized`](docs/api-reference/react/deckgl.md#onWebGLInitialized) callback or by passing them in `parameters` object to `drawLayer` method of `Layer` class. | |||
|
|
|||
|
|
|||
| ### assembleShaders | |||
|
|
|||
| `assembleShaders` was deprecated in v4.1 and now removed in v5. As described in v4.1 upgrade guide please use `Model` class instead. | |||
There was a problem hiding this comment.
I would rephrase this:
The assembleShaders function was moved to luma.gl in v4.1 and is no longer re-exported from deck.gl. As described ...., or import it from luma.gl where it is defined.x
docs/whats-new.md
Outdated
| @@ -78,7 +72,7 @@ Note: This change is mainly relevant to developers who write custom deck.gl laye | |||
|
|
|||
| ## Experimental Features | |||
|
|
|||
| As usual, deck.gl 4.2 contains a number of experimental features, e.g. multi viewport and first person viewport support. These features are still being finalized and the APIs have not been frozen, but can still be accessed by early adopters. See the roadmap article for more information on these. | |||
| As usual, deck.gl 4.2 contains a number of experimental features, e.g. `multi viewport`, `first person viewport` and `viewport transitions`. These features are still being finalized and the APIs have not been frozen, but can still be accessed by early adopters. See the roadmap article for more information on these. | |||
There was a problem hiding this comment.
Nit: Back ticks are usually for code symbols like actual class and function names, maybe normal quotes are more appropriate?
1chandu
force-pushed
the
moreDeprecationCleanup2
branch
from
ccd759f to
9c40eb8
Compare
1chandu
force-pushed
the
moreDeprecationCleanup2
branch
from
9c40eb8 to
0efb24d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified with
test-browserandexamples.