Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node label change #200

Merged
merged 8 commits into from
May 15, 2018
Merged

Node label change #200

merged 8 commits into from
May 15, 2018

Conversation

rbitia
Copy link
Contributor

@rbitia rbitia commented May 14, 2018

changed examples to use a nodeSelector rather than nodelabel

@rbitia rbitia requested a review from robbiezhang May 14, 2018 20:35
README.md Outdated
@@ -120,7 +120,7 @@ You can find detailed instructions on how to set it up and how to test it in the
#### Configuration File

The Azure connector can use a configuration file specified by the `--provider-config` flag.
The config file is in TOML format, and an example lives in `providers/azure/example.toml`.
The config file is in TOML format, and an examplegit lives in `providers/azure/example.toml`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert?

Ria Bhatia added 2 commits May 15, 2018 09:44
changed a typo
spacing issue
@rbitia
Copy link
Contributor Author

rbitia commented May 15, 2018

fixed typo so merging

@rbitia rbitia merged commit 4b61932 into master May 15, 2018
@rbitia rbitia deleted the nodeLabelChange branch June 1, 2018 19:06
cpuguy83 pushed a commit to cpuguy83/virtual-kubelet that referenced this pull request Feb 27, 2019
* adding provider info

* adding readme edits

* test change

* added node selector

* node selector changes

* Update README.md

changed a typo

* Update README.md

spacing issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants