Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnPanStart, Update and End Gestures callbacks #21

Closed
nooralibutt opened this issue Feb 22, 2021 · 5 comments
Closed

OnPanStart, Update and End Gestures callbacks #21

nooralibutt opened this issue Feb 22, 2021 · 5 comments
Assignees
@vintage
Labels
enhancement New feature or request

Comments

@nooralibutt
Copy link

I need these callbacks outside so that I can implement sound effects while user scratches.
@vintage
Copy link
Owner

vintage commented Feb 22, 2021

Sounds like a reasonable use case to cover. Will expose additional callbacks later this week.

@vintage vintage self-assigned this Feb 22, 2021
@vintage vintage added the enhancement New feature or request label Feb 22, 2021
vintage added a commit that referenced this issue Feb 22, 2021
@vintage
Expose scratching callbacks (start, update, end) #21
96572aa
@vintage
Copy link
Owner

vintage commented Feb 22, 2021

@nooralibutt done. onScratchStart, onScratchUpdate and onScratchEnd landed in 1.4.1 https://pub.dev/packages/scratcher ;)

@vintage vintage closed this as completed Feb 22, 2021
@nooralibutt
Copy link
Author

@vintage wow, amazing. Job well done.

Although, I don't need it but I think you should have passed the details argument with these callbacks, that was comping with pan gesture. Thanks though.

@vintage
Copy link
Owner

vintage commented Feb 23, 2021

Nah, I don't see any real use-case for these. Will add meaningful data to the callbacks when proper issue got reported.

@nooralibutt
Copy link
Author

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vintage vintage

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vintage @nooralibutt