Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name 'basestring' is not defined :: python3 #62

Closed
thornomad opened this issue Jun 23, 2015 · 1 comment
Closed

name 'basestring' is not defined :: python3 #62

thornomad opened this issue Jun 23, 2015 · 1 comment

Comments

@thornomad
Copy link

Hi there - thanks for this!

There is an error in Python3 (works in Python2) triggered with v.upload_picture:

File "/usr/local/lib/python3.4/site-packages/vimeo/upload.py", line 105, in upload_picture
    if isinstance(obj, basestring):
NameError: name 'basestring' is not defined

I think this can be fixed fairly easily with a try/except statement upon import ... is it something you would be willing to fix? I can create a pull request if that would help.

Could use this as a model: oxplot/fysom#1

Damon
@Dashron
Copy link
Contributor

Dashron commented Jun 25, 2015

Thanks for the info! Sending it off to one of our python devs.

@greedo greedo closed this as completed in 4c1df02 Jun 25, 2015
greedo added a commit that referenced this issue Jun 25, 2015
@greedo
Merge pull request #63 from greedo/python3_basestring
b6a574f 
fixes #62, basestring import str for Python3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thornomad @Dashron