VIALJS-112: Fixed issues with the timing of saving settings and the verify-sinks bg call. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erify-sinks bg call.
ghost
approved these changes
Oct 22, 2018
ghost
approved these changes
Oct 22, 2018
ghost
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Saving settings after changing redundant headset doesn't remove them immediately.
To reproduce: set a usb device as your audio device(s) in Vialer-js settings and save. Remove the device. You'll be redirected to the audio settings tab and a warning shows that the device is removed/invalid. Change to a different device. The redundant device should be removed on save immediately. What actually happens is that you have to save again, before the device is removed.
Approach
Settings weren't always saved when the
bg:devices:verify-sinksevent was emitted. Moved the emission of the event in the callback to solve it.