VIALJS-15: Added test for phonenumber matching. #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Unit tests for the phonenumber parser of the observer content script.
Approach
This is only a start, far from complete. For this unit I only invoked the parser on texts. It would probably be a good idea to also make a test that runs in puppeteer.
Open Questions and Pre-Merge TODOs
Learning
Had to use
jsdom
because the parser usesdocument.createElement
in some places.