Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIALJS-15: Added test for phonenumber matching. #191

Merged
merged 1 commit into from
Oct 11, 2018
Merged

VIALJS-15: Added test for phonenumber matching. #191

merged 1 commit into from
Oct 11, 2018

Conversation

c0deaddict
Copy link
Contributor

Purpose

Unit tests for the phonenumber parser of the observer content script.

Approach

This is only a start, far from complete. For this unit I only invoked the parser on texts. It would probably be a good idea to also make a test that runs in puppeteer.

Open Questions and Pre-Merge TODOs

  • Use github checklists. When solved, check the box and explain the answer.

Learning

Had to use jsdom because the parser uses document.createElement in some places.

@c0deaddict c0deaddict requested a review from a user October 10, 2018 08:03
@c0deaddict c0deaddict self-assigned this Oct 10, 2018
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@c0deaddict c0deaddict merged commit fb64991 into vialer:develop Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant