This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
Stop containers after tests #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tests:stop-and-cleanup` script has been renamed to `tests:cleanup`.
borekb
added
scope: dev-infrastructure
This script is meant to be used with additional arguments, e.g.: ``` npm run tests:custom-with-wordpress -- -c phpunit.xml --filter RevertTest ``` So it cannot contain "; npm run tests:stop".
Docker stack now needs to be started manually as it's auto-shutdown when tests finish running.
borekb
changed the title
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1389
npm run tests:fullnow automatically stop the containers after the tests finish running (both successfully and with failures).The
tests:stop-and-cleanupscript has been renamed to a simplertests:cleanupand docs updated.