This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
Run tests in Travis #1381
Merged
Run tests in Travis #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GH access token can be leaked by malicious PRs Undoes aa69729
Undoes 64922d6
|
This is awesome! ❤️ I'm inclined to merge this before the tests pass, do you agree? |
|
Absolutely! |
borekb
added
the
noteworthy
|
I wonder if it's useful to run |
I think it is. If Travis doesn't build the images, then Travis can't test changes to the images. For example, if you modify a Dockerfile, and Travis isn't building images, then Travis won't be able to run tests with that change in place. This means docker changes can only be tested locally or after the image is pushed. |
|
👍, you're right. It's a bit wasteful most of the time but we could add something like this in the future. |
Merged
borekb
removed
the
noteworthy
borekb
added
scope: dev-infrastructure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: this has been reverted in #1394
Issue: #1259
Have Travis run all tests:
With this improvement, tests are automatically run so no one has to manually do so. Tests are also run for all branches and PRs allowing for test passage to be a quality gate.