Refactoring For loop #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A refactoring in order to remove a for loop and possibly optimize this a bit.
fentas
reviewed
Dec 27, 2017
lib/commands.js
Outdated
| var lowerCaseCommands = commands.map(function (item) { | ||
| return item.toLowerCase(); | ||
| }); | ||
| return lowerCaseCommands.indexOf(command) !== -1 ? true : false; |
There was a problem hiding this comment.
The ternary operator is unnecessary here.
Added that for readability since its a common idiom of the JS language
|
@fentas Added edits to the PR |
|
that does look much nicer. sorry i just saw this! |
|
@justinvforvendetta No worries! I know you're swamped! I'd love to become a collaborator to Verge in any way that I could. Let me know if you all need help with anything always love developing PHP and JS. I thought about making this into an npm module that your could download, but I wanted to wait to clear with you all first 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring in order to remove a for loop and possibly optimize this a bit.