test(turborepo): Create Cache Tests #5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
NicholasLYang
force-pushed
the
nicholasyang/create-cache-tests
branch
from
bc15cb5 to
2675f33
Compare
🟢 CI successful 🟢Thanks |
NicholasLYang
force-pushed
the
nicholasyang/create-cache-tests
branch
from
2675f33 to
84b08c2
Compare
NicholasLYang
force-pushed
the
nicholasyang/create-cache-tests
branch
2 times, most recently
from
6aa518f to
5da6ac7
Compare
NicholasLYang
force-pushed
the
nicholasyang/create-cache-tests
branch
2 times, most recently
from
c3d0e8b to
f205209
Compare
arlyon
approved these changes
Jul 6, 2023
arlyon
reviewed
Jul 6, 2023
| let mut encoder = zstd::Encoder::new(&mut buffer, 0)?.auto_finish(); | ||
| encoder.write(b"hello world")?; | ||
| // Should finish encoding on drop | ||
| drop(encoder); |
There was a problem hiding this comment.
That feels odd to me but it makes sense. Coming from the hash / digest api I am surprised but I guess since the digest apis spit out data when you finalize rather than (I assume) write it as you go it makes sense to have 'implicit finalize' on drop.
There was a problem hiding this comment.
Yeah we could require an explicit finalize, but that's too easy to miss imo, so it's probably better to just finalize on drop
arlyon
reviewed
Jul 6, 2023
| @@ -33,8 +34,9 @@ impl CacheReader { | |||
|
|
|||
| pub fn open(path: &AbsoluteSystemPathBuf) -> Result<Self, CacheError> { | |||
| let file = path.open()?; | |||
| let is_compressed = path.extension() == Some("zst"); | |||
There was a problem hiding this comment.
Probably worth discussing here whether we want to check for the zstd magic number as well / instead / as a fallback? It'll be slower in the general case but then we are not dependent on the file name causing issues
There was a problem hiding this comment.
I'll defer to @gsoltis on that, but we should probably keep the same Go behavior until we're done with the port
NicholasLYang
force-pushed
the
nicholasyang/create-cache-tests
branch
from
f205209 to
0b28534
Compare
|
✅ This change can build |
Linux Benchmark for ecf5740Click to view benchmark
|
NicholasLYang
force-pushed
the
nicholasyang/create-cache-tests
branch
from
bf3de20 to
0a8c365
Compare
Linux Benchmark for 6070821Click to view benchmark
|
NicholasLYang
force-pushed
the
nicholasyang/create-cache-tests
branch
from
0a8c365 to
398f794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests for creating a cache. These do have different hashes than the Go ones, but I think that's fine since there's no expectation that tar construction or zstd compression is necessarily deterministic.
Testing Instructions