Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vercel/turborepo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.4
Choose a base ref
...
head repository: vercel/turborepo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.5
Choose a head ref
  • 8 commits
  • 20 files changed
  • 6 contributors

Commits on Mar 20, 2023

  1. release(turborepo): 1.8.4 (#4267)

    Co-authored-by: Turbobot <turbobot@vercel.com>
    github-actions[bot] and turbobot-temp authored Mar 20, 2023
    11 Configuration menu
    Copy the full SHA
    35f31f0 View commit details
    Browse the repository at this point in the history
  2. Add valid JSON into test fixture (#4269)

    The lint-staged precommit hook scans all package.jsons
    in the repo and attempts to load configuration from them.
    Because this one doesn't contain valid JSON, lint-staged throws
    an error on every commit.
    mehulkar authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    6bc8b5e View commit details
    Browse the repository at this point in the history
  3. If a graph walk task fails, stop the walk. (#4254)

    ### Description
    
    Backstory: I was investigating what needs to be done to support unifying
    our output to support grouping log output. I encountered an `os.Exit`
    sitting in run, and while attempting to address that, discovered that we
    don't fully stop on error even when we mean to. We stop executing
    _scripts_ but we continue to walk the graph, meaning that we can trigger
    cache restorations.
    
    This PR:
    - Adds a short-circuiting mechanism to our graph walk so that tasks
    started after the failed tasks are skipped. Note that tasks started
    concurrently with the failed task may still run.
    - Remove the `os.Exit` for the case where we fail to do the setup work
    to capture task outputs
    - Adds a test for short-circuiting using a custom visitor to
    deterministically inject an error into graph traversal
    
    ### Testing Instructions
    
    New test in `engine_test.go` demonstrates short-circuiting by injecting
    an error into graph traversal.
    
    I opted for a unit test in this case because using a failing script in
    an integration test will not trigger the broken behavior. We shut down
    the script-running facility once a script fails. The error needs to
    occur outside of the user's script to demonstrate the bug, hence a
    custom graph visitor.
    
    ---------
    
    Co-authored-by: Mehul Kar <mehul.kar@vercel.com>
    Greg Soltis and mehulkar authored Mar 20, 2023
    1 Configuration menu
    Copy the full SHA
    3db969f View commit details
    Browse the repository at this point in the history
  4. feat(ecmascript): support jsximport/runtime options (#4198)

    ### Description
    
    First part of WEB-719 implementation. PR expands enable_jsx option to
    accept few more configuration point to jsx transforms, mainly its import
    source. We'll likely to expand options more in the future.
    
    One thing I noted in the code but didn't make change is
    `enable_react_refresh`, if it needs to be under the jsx option or should
    be independent. Given react_refresh only should be enabled when jsx is
    enabled, for me it makes more sense to move it.
    kwonoj authored Mar 20, 2023
    1 Configuration menu
    Copy the full SHA
    a52e66b View commit details
    Browse the repository at this point in the history
  5. feat(turbopack_ecmascript): support legacy decorators transform (#4187)

    ### Description
    
    Partially implements WEB-667. 
    
    This is second attempt to implement decorators support. The crux is
    pretty much same as previous changes to support runtime ts config
    options - PR enables to accept & perform decorators transform. One thing
    to note is we apply this transform for the ecma / typescript regardless,
    since decorators can be applied in either cases.
    
    Given next-* is moved to next.js, subsequent changes to next.js is
    required to close the issue. Will work on once this lands.
    kwonoj authored Mar 20, 2023
    1 Configuration menu
    Copy the full SHA
    5574379 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Revert rust scm usage (#4277)

    ### Description
    
    Drop hook to rust implementation of scm. There is an error with
    `turbo-ignore`
    
    ### Testing Instructions
    
    Existing unit + integration tests
    Greg Soltis authored Mar 21, 2023
    1 Configuration menu
    Copy the full SHA
    995aae2 View commit details
    Browse the repository at this point in the history
  2. send a SIGTERM on unix rather than just killing the process (#4276)

    ### Description
    
    In attempting to fix a zombie process on windows, we accidentally
    introduced a similar issue on unix. This makes sure to gracefully stop
    the go binary so that it may in turn gracefully stop its children rather
    than leave them hanging.
    
    ### Testing Instructions
    
    Check out front. On 1.8.4 running multiple `turbo dev --filter
    vercel-site` can sometimes cause a race condition where the node process
    is left hanging causing errors regarding ports being used. It seems to
    happen in a bout 1 in 5 or so runs and only when quitting at specific
    times. Checking out this PR, you can observe that crtl-c works as
    expected, and the existing, correct, windows behaviour still works.
    arlyon authored Mar 21, 2023
    1 Configuration menu
    Copy the full SHA
    4e46123 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99ff6be View commit details
    Browse the repository at this point in the history
Loading