Create delegate method for changes in tokenFieldHeight #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (oldHeight != height | ||
| && [self.delegate respondsToSelector:@selector(tokenField:didChangeContentHeight:)]) { | ||
| [self.delegate tokenField:self didChangeContentHeight:height]; | ||
| } |
There was a problem hiding this comment.
Do we need to also call [self setHeight:] when there is no delegate set for backwards compatibility?
There was a problem hiding this comment.
thanks for that catch @ayanonagon
done in a6c26aa
|
🍏 Thanks for making the change! |
dasmer
added a commit
that referenced
this pull request
Jan 6, 2016
Create delegate method for changes in tokenFieldHeight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, implementations that use auto-layout can respond to height changes by modifying height constraint constants.