Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullability annotations #81

Merged
merged 6 commits into from
Sep 30, 2015
Merged

Add nullability annotations #81

merged 6 commits into from
Sep 30, 2015

Conversation

hyperspacemark
Copy link
Contributor

Fixes #80.

  • Bump CocoaPods install version to 0.38.2.
  • Add LLVM nullability annotations to provide a better interface to Swift consumers.
  • Fix a warning in -[VENToken initWithFrame:] due to our implementation colliding with -[UIView initWithFrame:]s NS_DESIGNATED_INITIALIZER annotation.

`-[UIView initWithFrame:]` is annotated with the
`NS_DESIGNATED_INITIALIZER` macro so it is expected that subclasses
will invoke the superclass’s implementation. Because we load our user
interface from a nib but still want to allow users to initialize an
instance with `-initWithFrame:`, we do not call super and instead
assign `self` to the result of unarchiving the aforementioned nib. This
causes a warning to be emitted about not calling `super`.

Since we know what we’re doing, we can work around this warning by just
calling `super` before we unarchive from the nib to appease the
compiler.
@eliperkins
Copy link

🍏 Thanks for taking care of this!

Once you fix the merge conflicts, feel free to merge.

hyperspacemark added a commit that referenced this pull request Sep 30, 2015
Add nullability annotations
@hyperspacemark hyperspacemark merged commit c230c74 into master Sep 30, 2015
@hyperspacemark hyperspacemark deleted the ma/nullability branch September 30, 2015 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants