Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve collapse test, and reset view state after basic flow test #46

Merged
merged 1 commit into from
Jan 21, 2015

Conversation

brockboland
Copy link
Contributor

Fixes #42

@ayanonagon
Copy link
Contributor

This is great, thank you! :octocat: One question, wouldn’t the test fail if any of the tests runs before the first test?

@brockboland
Copy link
Contributor Author

It shouldn't! I added back-spacing at the end of testBasicFlow to reset to the starting state, and confirmed that testResignFirstResponderAndCollapse works when run alone or as part of the full suite of tests.

@ayanonagon
Copy link
Contributor

I guess testResignFirstResponderAndCollapse puts you in the 3 people state, but doesn’t affect the other tests. 👍

@brockboland
Copy link
Contributor Author

Ooh, good point: testResignFirstResponderAndCollapse is NOT resetting things to the starting state. It seems like there should be an afterEach method to clean things up, but it's tough because there's not a good way to clear all the existing tokens through KIF without simulating a bunch of backspaces.

@ayanonagon
Copy link
Contributor

Yeah, definitely a little tough. For now though, this is a huge improvement, so I’ll merge it in. Thanks again @brockboland! :octocat:

ayanonagon added a commit that referenced this pull request Jan 21, 2015
Improve collapse test, and reset view state after basic flow test
@ayanonagon ayanonagon merged commit abf667d into venmo:master Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testResignFirstResponderAndCollapse is not independent
2 participants