Skip to content

Use content-dispositon package #820

Closed
@Prinzhorn

Description

https://www.npmjs.com/package/content-disposition

These three occurrences would benefit from using a proper package. Because the format is not as trivial as they make it look.

http.response.setHeader('Content-Disposition', dispositionType + dispositionName + dispositionEncoding);

https://github.com/veliovgroup/Meteor-Files/blob/master/docs/gridfs-bucket-integration.md#4-create-download-handler
https://github.com/veliovgroup/Meteor-Files/blob/7f67a0885e120ad77085b191e3399add575a2d89/docs/gridfs-streaming.md

E.g. this will break easily:

http.response.setHeader('Content-Disposition', `inline; filename="${file.name}"`);

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions