Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for named tuple members #1236

Merged
merged 1 commit into from
May 25, 2022
Merged

feat: support for named tuple members #1236

merged 1 commit into from
May 25, 2022

Conversation

filipomar
Copy link
Contributor

@filipomar filipomar commented May 1, 2022 •
edited by github-actions bot
Loading

  • Fixes lack of named tuples mentioned here, but does not add titles to named variadic tuples rest element.
  • Fixes broken url on documentation

Version

Published prerelease version: v1.1.0-next.4

Changelog

🎉 This release contains work from new contributors! 🎉

Thanks for all your work!

❤️ null@filipomar

❤️ Remi Cattiau (@loopingz)

❤️ Hadrien Milano (@hmil)

🚀 Enhancement

🐛 Bug Fix

🔩 Dependency Updates

Authors: 8

domoritz
domoritz approved these changes May 1, 2022
View reviewed changes
src/NodeParser/NamedTupleMemberNodeParser.ts Outdated

if (baseType instanceof ArrayType && node.getChildAt(0).kind === ts.SyntaxKind.DotDotDotToken) {
/**
* @todo investigate how to annotate rest type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use // TODO: or fix this.

domoritz
domoritz approved these changes May 2, 2022
View reviewed changes
src/NodeParser/NamedTupleMemberNodeParser.ts Outdated
const baseType = this.childNodeParser.createType(node.type, context, reference);

if (baseType instanceof ArrayType && node.getChildAt(0).kind === ts.SyntaxKind.DotDotDotToken) {
// TODO: investigate how to annotate rest type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a issue and link to it from here. It's unclear what this todo is doing here. Can you fix it instead?

@domoritz domoritz changed the title fix: giving support to named tuple members fix: support for named tuple members May 3, 2022
@domoritz domoritz changed the title fix: support for named tuple members feat: support for named tuple members May 3, 2022
@domoritz
Copy link
Member

domoritz commented May 3, 2022

Can you elaborate why there is a todo in the code? Please instead file an issue with a detailed explanation and explain why you didn't fix it here.

@filipomar filipomar force-pushed the named-tuple-member branch 4 times, most recently from f49d0b2 to 56f75d2 Compare May 25, 2022 17:26
@filipomar filipomar requested a review from domoritz May 25, 2022 18:08
@filipomar filipomar force-pushed the named-tuple-member branch from 7bf5a18 to 4b357a5 Compare May 25, 2022 18:51
@filipomar @cybuspomar
feat: support for named tupple members
7cf221d 
fix: broken code of conduct documentation link
fix: code style formatting
fix: corrected error message
@filipomar filipomar force-pushed the named-tuple-member branch from 4b357a5 to 7cf221d Compare May 25, 2022 18:53
@domoritz domoritz merged commit 42ce3b6 into vega:next May 25, 2022
@filipomar filipomar deleted the named-tuple-member branch May 25, 2022 21:56
@github-actions github-actions bot mentioned this pull request May 26, 2022
Merged
This was referenced Sep 21, 2022
Merged
Merged
@github-actions
Copy link

🚀 PR was released in v1.1.0 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz Awaiting requested review from domoritz

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipomar @domoritz