go mod and vendoring #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a discrepancy of behavior of `github.com/urfave/cli` between using go1.12 and go1.15, when the dependency is not present as vendored source. Now this builds fine with go1.12 There are users of tar-split as a package. It is the hope that by adding this vendored source it does not impact them depending on tar-split itself. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
tianon
reviewed
Oct 27, 2020
| @@ -0,0 +1,8 @@ | |||
| module github.com/vbatts/tar-split | |||
|
|
|||
| go 1.15 | |||
There was a problem hiding this comment.
This could be set as low as 1.11 (IIRC), and that might help the Go tool understand the level of compatibility you're shooting for? 😇
There was a problem hiding this comment.
Fair. The travis test went back to g1.10 and that's green, sooo...
|
thanks and it works fine now for power on arch,I am planning to raise PR for supporting ppc64le cpu arch soon.really thanks for your swift action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
There is a discrepancy of behavior of
github.com/urfave/clibetween using go1.12 and go1.15, when the dependency is not present as vendored source. Now this builds fine with go1.12There are users of tar-split as a package. It is the hope that by adding this vendored source it does not impact them depending on tar-split itself.
also, travis: test from go1.10 - go1.15