Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tabs component adds scrollable and indicatorPosition props #921

Merged
merged 6 commits into from
Mar 22, 2023

Conversation

tiny-dust
Copy link
Collaborator

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information


@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
varlet ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 4:49AM (UTC)
varlet-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 4:49AM (UTC)

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Merging #921 (03975ae) into dev (0ae8c5e) will increase coverage by 0.07%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #921      +/-   ##
==========================================
+ Coverage   94.53%   94.60%   +0.07%     
==========================================
  Files         275      275              
  Lines        6129     6120       -9     
  Branches     1067     1068       +1     
==========================================
- Hits         5794     5790       -4     
+ Misses        335      330       -5     
Impacted Files Coverage Δ
packages/varlet-ui/src/tabs/Tabs.vue 81.81% <100.00%> (+6.52%) ⬆️
packages/varlet-ui/src/tabs/props.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haoziqaq
Copy link
Member

还需要提供类型声明文件,和单元测试文件。

@tiny-dust
Copy link
Collaborator Author

还需要提供类型声明文件,和单元测试文件。

好的,我明早补充

@tiny-dust tiny-dust changed the title feat: Tabs component adds two props feat: Tabs component adds scrollable and indicatorPosition props Mar 21, 2023
@haoziqaq
Copy link
Member

文档需要和案例效果有对应关系,需要加一个代码块去描述案例。另外案例为了一致性需要打开 elevation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab always scroll Tab activation position controllable
3 participants