Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:checkbox hover overlay #907

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

tiny-dust
Copy link
Collaborator

@tiny-dust tiny-dust commented Mar 15, 2023

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information


add hover overlay for component checkbox

issues #898

@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
varlet ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 7:17AM (UTC)
varlet-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 7:17AM (UTC)

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #907 (e6051dc) into dev (dd82f92) will increase coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #907      +/-   ##
==========================================
+ Coverage   94.55%   94.59%   +0.04%     
==========================================
  Files         275      275              
  Lines        6113     6123      +10     
  Branches     1112     1112              
==========================================
+ Hits         5780     5792      +12     
+ Misses        333      331       -2     
Impacted Files Coverage Δ
packages/varlet-ui/src/checkbox/Checkbox.vue 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haoziqaq
Copy link
Member

只需要将 checkboxicon 部分高亮即可,可以参考一下 material design 的设计规范

@tiny-dust
Copy link
Collaborator Author

只需要将 checkboxicon 部分高亮即可,可以参考一下 material design 的设计规范

ok

@haoziqaq
Copy link
Member

禁用时不需要 hover effect,建议参考 rate 最新的一次修改进行调整。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the hover instruction to the component checkbox、checkbox-group
3 participants