Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rate hover overlay by v-hover #906

Merged
merged 4 commits into from
Mar 15, 2023
Merged

feat: rate hover overlay by v-hover #906

merged 4 commits into from
Mar 15, 2023

Conversation

dyggod
Copy link
Member

@dyggod dyggod commented Mar 14, 2023

fix #900

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information


@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
varlet ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 10:50AM (UTC)
varlet-ui-playground ❌ Failed (Inspect) Mar 15, 2023 at 10:50AM (UTC)

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Merging #906 (17be53e) into dev (c78f4b2) will decrease coverage by 0.08%.
The diff coverage is 77.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #906      +/-   ##
==========================================
- Coverage   94.60%   94.52%   -0.08%     
==========================================
  Files         275      275              
  Lines        6098     6120      +22     
  Branches     1108     1112       +4     
==========================================
+ Hits         5769     5785      +16     
- Misses        329      335       +6     
Impacted Files Coverage Δ
packages/varlet-ui/src/rate/Rate.vue 96.77% <77.77%> (-3.23%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haoziqaq
Copy link
Member

只需要高亮指针指向的星星即可。

@dyggod
Copy link
Member Author

dyggod commented Mar 15, 2023

只需要高亮指针指向的星星即可。
好的,晚上改下

@dyggod
Copy link
Member Author

dyggod commented Mar 15, 2023

修改好了。那个varlet-ui-playground的check失败是什么意思?需要怎么调整 @haoziqaq

@haoziqaq
Copy link
Member

@dyggod vercelcli 改东西了,刚修复,可以不管

@haoziqaq haoziqaq merged commit 6a6a2d0 into varletjs:dev Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the hover instruction to the component rate
3 participants