Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LogService methods and api endpoint url. Fixes #74 Closes #73 #75

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Rename LogService methods and api endpoint url. Fixes #74 Closes #73 #75

merged 3 commits into from
Feb 8, 2024

Conversation

m29h
Copy link
Collaborator

@m29h m29h commented Dec 12, 2023

No description provided.

@m29h m29h added the bug Something isn't working label Dec 12, 2023
@m29h
accept empty result during integration test.
d38de21 
Rename tests to match new method names
@coveralls
Copy link

coveralls commented Dec 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7189000272

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.2%) to 90.805%
Files with Coverage Reduction New Missed Lines %
pocketbase/services/log_service.py 2 88.89%
pocketbase/models/log_request.py 10 56.52%
Totals Coverage Status
Change from base Build 6198373417: -1.2%
Covered Lines: 790
Relevant Lines: 844
💛 - Coveralls

@m29h m29h requested a review from vaphes December 12, 2023 23:46
@m29h m29h changed the title Rename LogService methods and api endpoint url. Fixes #74 Rename LogService methods and api endpoint url. Fixes #74 Closes #73 Dec 13, 2023
@vaphes vaphes merged commit bdbaf7e into vaphes:master Feb 8, 2024
5 checks passed
@m29h m29h deleted the fix_issue_74 branch February 8, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaphes vaphes vaphes approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m29h @coveralls @vaphes