Add sample with custom view. #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
|
Fixed. |
Signed-off-by: Mario Danic <mario@lovelyhq.com>
|
I merged my emoji filter branch + additional commit to fix stuff. |
|
What do we do here? |
rubengees
previously approved these changes
Nov 24, 2019
|
@vanniktech can you rebase so we can merge? :) |
|
@mario |
|
I will check. I use adjust resize all the time.
…On Thu, 30 Jan 2020, 11:58 Niklas Baudy, ***@***.***> wrote:
@mario <https://github.com/mario> adjustResize is broken though. Custom
view + adjustResize does not work. How come?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#409?email_source=notifications&email_token=AAABNMWZ5APDE3IXSDF2Z7LRAKXFVA5CNFSM4JEBJUQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKKSJHA#issuecomment-580199580>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABNMV2FC4VPEMRAK4QKE3RAKXFVANCNFSM4JEBJUQQ>
.
|
|
@mario ready for a review. Have you had time to look into adjustResize? |
Signed-off-by: Mario Danic <mario@lovelyhq.com>
|
@vanniktech can you check it out now pls? |
|
Indeed @mario. I've tweaked it so that the custom view contains all of the views / popup. |
mario
approved these changes
Apr 10, 2020
|
@rubengees can you check this out and merge if you agree? :) Otherwise I'll merge in a week. Thanks! |
|
@vanniktech what's up with travis here? Stuck? |
|
Yeah. Seems like it |
|
I can't merge since I am not an admin...
…On Sun, 19 Apr 2020, 15:15 Niklas Baudy, ***@***.***> wrote:
Yeah. Seems like it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#409 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABNMWRU7BIE6WPZWZCNMLRNL2QDANCNFSM4JEBJUQQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does work with 95e0c8e but not with ee9b8eb