Dependency updates #188
Dependency updates #188
Conversation
| @@ -30,6 +30,7 @@ | |||
| import com.vanniktech.emoji.one.EmojiOneProvider; | |||
| import com.vanniktech.emoji.twitter.TwitterEmojiProvider; | |||
|
|
|||
| @SuppressWarnings("CPD-START") // We don't care about duplicate code in the sample. | |||
There was a problem hiding this comment.
Found here: https://stackoverflow.com/a/18625921/4279995
Not optimal, but I think there is no better way...
build.gradle
Outdated
| ] | ||
|
|
||
| repositories { | ||
| jcenter() | ||
| google() | ||
| maven { url "https://plugins.gradle.org/m2/" } |
There was a problem hiding this comment.
We need this for the gradle-errorprone-plugin.
There was a problem hiding this comment.
We don't. The code quailty plugin takes care of that.
There was a problem hiding this comment.
Oops, I'll revert it.
| @@ -189,16 +189,6 @@ public void noProviderInstalled() { | |||
| assertThat(text.getSpans(0, text.length(), EmojiSpan.class)).hasSize(1); | |||
| } | |||
|
|
|||
| @Test public void takeLongest() { | |||
There was a problem hiding this comment.
This was a duplicate of the halfPath test.
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 27.82% 27.82%
=======================================
Files 22 22
Lines 805 805
Branches 88 88
=======================================
Hits 224 224
Misses 563 563
Partials 18 18
Continue to review full report at Codecov.
|
build.gradle
Outdated
| @@ -4,7 +4,7 @@ apply plugin: 'com.vanniktech.android.junit.jacoco' | |||
|
|
|||
| buildscript { | |||
| ext.versions = [ | |||
| testRules: '0.5', | |||
| testRules: '1.0.0', | |||
There was a problem hiding this comment.
i haven't had luck with 1.0.0 and espresso 3.0.0. Did you test locally whether the screenshots are being taken or not. You can do so using gw assembleDebug assembleAndroidTest && fastlane screengrab
There was a problem hiding this comment.
You are right, at first it did not work. Managed to fix with my latest commit though.
build.gradle
Outdated
|
|
||
| classpath 'com.android.tools.build:gradle:2.3.3' | ||
| classpath 'com.github.ben-manes:gradle-versions-plugin:0.15.0' | ||
| classpath 'net.ltgt.gradle:gradle-errorprone-plugin:0.0.11' |
There was a problem hiding this comment.
not needed. The code quailty plugin takes care of that.
| @@ -4,7 +4,8 @@ apply plugin: 'com.vanniktech.android.junit.jacoco' | |||
|
|
|||
| buildscript { | |||
| ext.versions = [ | |||
| testRules: '0.5', | |||
| espresso: '3.0.0', | |||
There was a problem hiding this comment.
Concerning screengrab: Something set a different version, so I redefinied it here. Why does that happen?
There was a problem hiding this comment.
Oh it was simply missing here in the first place. Now it should be all good.
| @@ -4,7 +4,8 @@ apply plugin: 'com.vanniktech.android.junit.jacoco' | |||
|
|
|||
| buildscript { | |||
| ext.versions = [ | |||
| testRules: '0.5', | |||
| espresso: '3.0.0', | |||
There was a problem hiding this comment.
Oh it was simply missing here in the first place. Now it should be all good.
As the title says.