Beautify demo page #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <input type="text" id="carPlate"> | ||
|
|
||
| <h4>Vehicle Identification</h4> | ||
| <label for="vin">Vehicle identification</label> | ||
| <input type="text" id="vin"> | ||
| </fieldset> | ||
|
|
There was a problem hiding this comment.
The indentation of this whole file it's a little strange.
There was a problem hiding this comment.
I don't know why, cause it's normal in my local file... 😕
There was a problem hiding this comment.
@regishideki, have you differentiate tab from space in your local editor ?
Looks like it has been indent with tabs.
|
@leandroadacosta and @caio-ribeiro-pereira , what do you think about this PR? Can I merge it? |
|
It looks okay. I think you can merge. Not a huge change. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conformance with TODO list on VanillaMasker's page, I'm sending this pull request to improve demo page's layout.
I've tried to centralize legend content but I read this tag is not standardized amoung browsers. Some people say it's better to use a h tag instead. What do you think?
How demo page is now
Proposal:
