I was looking into this and the problem is buried inside the OS openID library we use. It's going to take a bit of brain power to fix it so I need to push this off until the next release.

I might have a related problem: when I try to login with a LiveJournal openID, I get "Email is required".

@tburry, how does it related to lightopenid? As far as I've checked that out the problem occurs since validation is being called twice (which should not happen). So, validation fails and everything else then goes wrong. Gonna dig into it deeper tomorrow.

yes that is right becuase it posts back to the same form.

The openid is valid

Solved

replace

<?php
....
$OpenID = $this->GetOpenID();
if ($OpenID->validate()) {
     $Attr = $OpenID->getAttributes();
     $Form = $Sender->Form; //new Gdn_Form();
     $ID = $OpenID->identity;
     $Form->SetFormValue('UniqueID', $ID);
     $Form->SetFormValue('Provider', self::$ProviderKey);
     $Form->SetFormValue('ProviderName', 'OpenID');
     $Form->SetFormValue('FullName', GetValue('namePerson/first', $Attr).' '.GetValue('namePerson/last', $Attr));
     $Form->SetFormValue('Email', GetValue('contact/email', $Attr));
     $Sender->SetData('Verified', TRUE);
}  

with

<?php
....
session_start();
if(!isset($_SESSION['OpenID'])){
     $OpenID = $this->GetOpenID();
}else{
     $OpenID = $_SESSION['OpenID'];
}
if(isset($_SESSION['OpenID']) || $OpenID->validate()){
     $Attr = $OpenID->getAttributes();
     $Form = $Sender->Form; //new Gdn_Form();
     $ID = $OpenID->identity;
     $Form->SetFormValue('UniqueID', $ID);
     $Form->SetFormValue('Provider', self::$ProviderKey);
     $Form->SetFormValue('ProviderName', 'OpenID');
     $Form->SetFormValue('FullName', GetValue('namePerson/first', $Attr).' '.GetValue('namePerson/last', $Attr));
     $Form->SetFormValue('Email', GetValue('contact/email', $Attr));
     $Sender->SetData('Verified', TRUE);
     $_SESSION['OpenID']=$OpenID;
}      

Note I'm not using Gdn::Session(), perhaps it could be more elegant.

The idea is simple. Once validate, it doesn't not need to go through the same hoops, just carry over.

Auto-close has failed me. ff6510b

I am getting the same problem with my own openID provider. I just downloaded Vanilla, and see that the suggested changes are already present.
Is this problem resolved for the original reporter (@hanche)?

Sorry, I have been too busy lately, so I can't tell if the problem is resolved for me. Some time in December, I may find the time to do an upgrade and check it out.

OK. Thanks.

On Nov 9, 2011, at 5:14 AM, hanche reply@reply.github.com wrote:

Sorry, I have been too busy lately, so I can't tell if the problem is resolved for me. Some time in December, I may find the time to do an upgrade and check it out.

---

Reply to this email directly or view it on GitHub:
#907 (comment)