-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More conservative estimates for walking slopes #3982
More conservative estimates for walking slopes #3982
Conversation
It needs to get formatted properly. So you'll need to run |
src/sif/pedestriancost.cc
Outdated
1.40f, // -10.0% - 0.67 | ||
1.32f, // -8.0% - 0.73 | ||
1.26f, // -6.5% - 0.77 | ||
1.20f, // -5.0% - 0.82 | ||
1.12f, // -3.0% - 0.89 | ||
1.06f, // -1.5% - 0.94 | ||
1.00f, // 0.0% - 1.00 | ||
1.10f, // 1.5% - 1.06 | ||
1.20f, // 3.0% - 1.13 | ||
1.33f, // 5.0% - 1.22 | ||
1.43f, // 6.5% - 1.30 | ||
1.57f, // 8.0% - 1.38 | ||
1.83f, // 10.0% - 1.49 | ||
2.03f, // 11.5% - 1.58 | ||
2.23f, // 13.0% - 1.68 | ||
2.50f // 15.0% - 1.82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know this is a nitpick and im sorry in advance, what is the last number in the comment supposed to mean?
i had thought it was the "effective speed in MPH" after the factor is applied. so for example in the old code -10% = 3.16 / .67 = 4.71mph
but even looking at the old values it doesnt hold true for all of them!
and in your new comment i thought maybe it was just the reciprocal of the factor so like 1/1.06 = .94 but nearer to the ends of the scales this doesnt hold.
apologies if this is obvious, for whatever reason im just not getting it at the moment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, this is not properly explained: The last number is the one from Mountain Tactical Institute formula, i.e. math.exp(-0.04*slope)
; Its written there by my script https://gist.github.com/hungerburg/4936fa430552d625a0c8677f46492d1e - it is very similar to what is to get replaced, and in ascent also strikingly similar to the 400/800 variant of the DIN recipe.
The MTNT finding goes: Contrary to some conventional wisdom, instead of halving speed, 10% increase in incline only bring down speed one third. The new numbers say: nearly halve speed instead, at least in the observed range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for that! do you mind adding that info in comment form (the formula)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry, I'll do the format script for you, it's quickly done. Can you amend the comment before? Otherwise it'll likely get messed up again. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was just a single space between the comment and the value, just did it with the github editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks very much for this. i think if we can just do the one comment update and run the formatting script we'll be good to go. let me know if you want help running the script
And the changelog is important in this case:) |
Finally got what Changelog is about :) Sorry, I cannot run the script, would need to set up the whole build environment? I made the change completely in github web ui. I cannot amend from there, so before adding explanation of last column in table, can I do the formatting manually? |
Issue
#3969
Tasklist