Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix valhalla_export_edges null separator ( #3542 ) #3543

Merged
merged 2 commits into from
Feb 19, 2022
Merged

fix valhalla_export_edges null separator ( #3542 ) #3543

merged 2 commits into from
Feb 19, 2022

Conversation

ImreSamu
Copy link
Contributor

@ImreSamu ImreSamu commented Feb 19, 2022 •
edited
Loading

Issue

#3542 - "valhalla_export_edges : missing null columns separator"

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

  • none

kevinkreiser
kevinkreiser approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it was an std::string before. Using it as a cstring would not work. Thanks for the catch!

@kevinkreiser kevinkreiser merged commit 02c492b into valhalla:master Feb 19, 2022
@ImreSamu ImreSamu deleted the fix_export_edges_null branch February 19, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinkreiser kevinkreiser kevinkreiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImreSamu @kevinkreiser