Remove simple restriction check for pedestrians #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind adding a quick gurka test for this. We would be happy to show you how and it will prevent regressions in the future |
|
@kevinkreiser Sure. Can you share some more information how to do this or provide some example? |
|
@szymone yep actually you are in luck, we just had another similar PR where i asked the contributor to do just about the same thing (but for buses), let me know if this comment sheds any light: #3413 (comment) |
|
@kevinkreiser I've added one test for this. Can you look at it? |
|
@kevinkreiser Any update on this? Is this test enough to merge this PR? |
kevinkreiser
approved these changes
Nov 26, 2021
|
sorry for the delay on that im currently trying to take some days off while also fighting a pretty strong cold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3403