Exposing service-area names in passive maneuvers. #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me but i figure @dgearhart should review since hes the sinage expert |
dgearhart
reviewed
Aug 19, 2021
dgearhart
reviewed
Aug 19, 2021
| "Turn left toward Bear Peak. Then You will arrive at your destination.", | ||
| "Turn left toward Bear Peak.", | ||
| "Turn left toward Bear Peak. Then You will arrive at your destination.", | ||
| result, step_idx, "Turn left toward Bear Peak Rest Area.", |
There was a problem hiding this comment.
these expected results seem odd - I would try to mark all the edges with oneway - to be closer to real world. I know we still have more work to for Rest/Service Areas Use to make them work as exits instead of forks
There was a problem hiding this comment.
Hmm. I trust what you say is true. However, I didn't change this behavior. I'm just giving more real world names to the rest-area and service-area in this test.
There was a problem hiding this comment.
@ktatterso we will fix later - thanks
dgearhart
requested changes
Aug 19, 2021
dgearhart
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This is a minor extension to this prior project: #3172
Tasklist