Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates googletest to release-1.11.0 #3166

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Updates googletest to release-1.11.0 #3166

merged 2 commits into from
Jun 23, 2021

Conversation

purew
Copy link
Contributor

@purew purew commented Jun 22, 2021

Compiles on both gcc 11.1.0 and clang 12.0.0 on Linux 5.12.11-arch1-1(Archlinux).

Related to #3157 and #3112

cc @merkispavel @nilsnolde

@merkispavel
Copy link
Contributor

merkispavel commented Jun 23, 2021 •
edited
Loading

ah, damn..

FAILED: test/grid_range_query
: && ccache /usr/local/opt/ccache/libexec/c++ -fcolor-diagnostics  -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names -pagezero_size 10000 -image_base 100000000 test/CMakeFiles/grid_range_query.dir/grid_range_query.cc.o -o test/grid_range_query  test/libvalhalla_test.a  src/libvalhalla.a  /usr/local/lib/libprotobuf-lite.dylib  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/lib/libcurl.tbd  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/lib/libz.tbd  /usr/local/lib/libprime_server.dylib  /usr/local/lib/libspatialite.dylib  /usr/local/opt/sqlite3/lib/libsqlite3.dylib  /usr/local/lib/libluajit-5.1.dylib  lib/libgtest_main.a  lib/libgmock.a  lib/libgtest.a  -lpthread  /usr/local/lib/libgeos.dylib  /usr/local/lib/libgeos_c.dylib && :
Undefined symbols for architecture x86_64:
  "testing::internal2::PrintBytesInObjectTo(unsigned char const*, unsigned long, std::__1::basic_ostream<char, std::__1::char_traits<char> >*)", referenced from:
      std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > testing::PrintToString<std::__1::__hash_const_iterator<std::__1::__hash_node<int, void*>*> >(std::__1::__hash_const_iterator<std::__1::__hash_node<int, void*>*> const&) in grid_range_query.cc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

System specs:

Apple clang version 12.0.0 (clang-1200.0.32.21)
Target: x86_64-apple-darwin20.5.0
Thread model: posix

@nilsnolde
Copy link
Member

thanks @purew ! was under the impression clang 12 would be a problem, great that it works. urgh, just seeing the comment...

@purew
Copy link
Contributor Author

purew commented Jun 23, 2021 •
edited
Loading

I don't understand why testing::internal2::PrintBytesInObjectTo(unsigned char const*, unsigned long, std::__1::basic_ostream<char, std::__1::char_traits<char> >*)" wouldn't be defined on Macos 🤔

It seems to be this one and I see no immediate compile conditionals around it.

@merkispavel
Copy link
Contributor

I don't understand why testing::internal2::PrintBytesInObjectTo(unsigned char const*, unsigned long, std::__1::basic_ostream<char, std::__1::char_traits<char> >*)" wouldn't be defined on Macos 🤔

It seems to be this one and I see no immediate compile conditionals around it.

Damn. I haven't found a gtest lib in the system directories earlier, but I've just found the gtest & gmock headers in the /usr/local/include/. I believe this is the cause of the linker issues ^

I'm double checking that everything compiles and come back

@merkispavel merkispavel mentioned this pull request Jun 23, 2021
Closed
merkispavel
merkispavel previously approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@merkispavel merkispavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@merkispavel
Copy link
Contributor

nit: maybe a good idea to make a note in the changelog

@mookerji mookerji self-requested a review June 23, 2021 21:31
@purew purew merged commit 988f210 into master Jun 23, 2021
@purew purew deleted the updates-gtest branch June 23, 2021 21:48
@nilsnolde nilsnolde mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandeepsandhu mandeepsandhu mandeepsandhu approved these changes

@mookerji mookerji mookerji approved these changes

@merkispavel merkispavel merkispavel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@purew @merkispavel @nilsnolde @mookerji @mandeepsandhu