@dgearhart I have not ideas how to test it as this variable isn't visible outside IsPedestrianFork function

@dgearhart I have not ideas how to test it as this variable isn't visible outside IsPedestrianFork function

Actually I have question - the way its written currently, nothing really sets xedge_use correct? GetStraightestTraversableIntersectingEdgeTurnDegree() will only set xedge_use if its not null, and since the caller - IsPedestrianFork(), never sets the pointer, it never gets used within it.

Previously, xedge_use had an undefined value, but GetStraightestTraversableIntersectingEdgeTurnDegree() could conditionally set it (eg if xedge->has_use == true). Now it seems it will never get set since its always initialized to nullptr when called in the context of IsPedestrianFork. Or am I missing somerthing?

since the caller - IsPedestrianFork(), never sets the pointer, it never gets used within it

The caller does set the "pointer"(i.e pointer to boost::optional).

boost::optional<TripLeg_Use> xedge_use;
// xedgeuse is a valid variable so &xedgeuse != nullptr
GetStraightestTraversableIntersectingEdgeTurnDegree(...,..., &xedge_use);

Check out the difference with the following piece of code

boost::optional<TripLeg_Use>* xedge_use = nulltpr;
GetStraightestTraversableIntersectingEdgeTurnDegree(...,..., xedge_use); // xedgeuse is null obviously

since the caller - IsPedestrianFork(), never sets the pointer, it never gets used within it

The caller does set the "pointer"(i.e pointer to boost::optional).

boost::optional<TripLeg_Use> xedge_use;
// xedgeuse is a valid variable so &xedgeuse != nullptr
GetStraightestTraversableIntersectingEdgeTurnDegree(...,..., &xedge_use);

Check out the difference with the following piece of code

boost::optional<TripLeg_Use>* xedge_use = nulltpr;
GetStraightestTraversableIntersectingEdgeTurnDegree(...,..., xedge_use); // xedgeuse is null obviously

Yup, makes sense. Thanks for the explanation! 👍

@merkispavel I would at least run RAD (master vs. branch) with the following files:

bicycle_routes.txt
demo_routes.txt
de_benchmark_routes.txt
eu_roundabout_routes.txt
pedestrian_roundabout_routes.txt
pedestrian_routes.txt
roundabout_routes.txt
timed_access_routes.txt
timed_conditional_routes.txt
turn_lane_routes.txt

@merkispavel I would at least run RAD (master vs. branch) with the following files:

bicycle_routes.txt
demo_routes.txt
de_benchmark_routes.txt
eu_roundabout_routes.txt
pedestrian_roundabout_routes.txt
pedestrian_routes.txt
roundabout_routes.txt
timed_access_routes.txt
timed_conditional_routes.txt
turn_lane_routes.txt

I RAD-tested the changes 🟢