ci: Update cache key to trigger clearing it #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
force-pushed
the
ml/azp-invalidate-cache-after-vs-update
branch
from
17ca106 to
4510fe3
Compare
mloskot
changed the title
Closed
Visual Studio 2019 has been updated from v16.8.5 to v16.9.0 and MSVC 14.28.29333 cached in CMake configuration is no longer accessible There is no way invalidate cache other than updating its cache: https://docs.microsoft.com/en-us/azure/devops/pipelines/release/caching#can-i-clear-a-cache Fixes valhalla#2945
mloskot
force-pushed
the
ml/azp-invalidate-cache-after-vs-update
branch
from
4510fe3 to
3cde169
Compare
|
It seems the |
|
@mloskot thank you for looking at this! let me know when you are ready for review |
|
@kevinkreiser I think it is ready to review. I introduced little convention to prefix the key with |
|
sweet, yep i see it built properly! ship it when ready! |
kevinkreiser
approved these changes
Mar 17, 2021
|
How do we handle the failing "Valhalla Changelog Validation / Changelog Validation" job? Ignore? |
|
@mloskot yep thats right, that check is just there to remind you to add it if the change is something you think needs a changelog entry. feel free to ignore it for this |
abhi2039
pushed a commit
to abhi2039/valhalla
that referenced
this pull request
Mar 30, 2021
…halla into pedestrian_crossing * 'pedestrian_crossing' of https://github.com/abhi2039/valhalla: build: Bail with error if non-existant build-type specified (valhalla#2965) nit: Enables compiler warnings in part of mjolnir module (valhalla#2922) fix missing comma scripts/valhalla_build_config (valhalla#2963) Remove duplicate names being used across different gurka tests (valhalla#2962) Dont abort bidirectional a* search if only one direction is exhausted (valhalla#2936) penalize uturns at pencil points and short internal edges (valhalla#2944) Remove unused IsNextEdgeInternal function (valhalla#2958) restore compatibility with gcc 6.3.0, libprotobuf 3.0.0, boost v1.62.0 (valhalla#2953) Add ability to build Valhalla modules as STATIC libraries (valhalla#2957) Allow disabling Werror (valhalla#2937) Enhanced logic for IsTurnChannelManeuverCombinable (valhalla#2952) Allow config object to be passed-in to path algorithms (valhalla#2949) Floating-point precision fix in meili::Project() fixes map-match issue (valhalla#2946) Use kServiceRoad edges while reclassifying ferry connections (valhalla#2933) ci: Update cache key to trigger clearing it (valhalla#2947)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Visual Studio 2019 has been updated from v16.8.5 to v16.9.0
and MSVC 14.28.29333 cached in CMake configuration is
no longer accessible
There is no way invalidate cache other than updating its cache:
https://docs.microsoft.com/en-us/azure/devops/pipelines/release/caching#can-i-clear-a-cache
Requirements / Relations
Fixes #2945