Fix cutting of response when traffic splits an edge into three parts #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the breakpoint, not the speed validity.
purew
reviewed
Mar 17, 2021
|
|
||
| // Regression is when breakpoint2 is set to 255, | ||
| // but speed3 is not set to UNKNOWN - we would incorrectly | ||
| // emit an additional 0-length slice in the API response |
There was a problem hiding this comment.
For my understanding, the case of speed3 or congestion3 being set while breakpoint2 is 255 is still an invalid state, but you're making the code more defensive to gracefully handle such an invalid state?
There was a problem hiding this comment.
Yeah - the old logic allowed for doing something in that case (breakpoint=255, but still emitting the third split). The code now correctly does not make the third split if breakpoint=255, so set values in speed3/congestion3 will be properly ignored.
kevinkreiser
approved these changes
Mar 17, 2021
|
feel free to ignore the non required windows build, theres a problem with CI rather than the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When traffic splits an edge into three parts, we were looking at the wrong field to determine if the third segment needs to exist. Edges are not often split this many times, and when the bug occurred, it resulted a zero-length geometry, so not a huge impact.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?