Added ukrainian translation #2882
Conversation
locales/uk-UA.json
Outdated
| @@ -0,0 +1,2149 @@ | |||
| { | |||
| "posix_locale": "uk_UA.UTF-8", | |||
| "aliases": "ukua", | |||
There was a problem hiding this comment.
aliases should be an array - the value should be "uk"
There was a problem hiding this comment.
Good catch. Fixed.
Can I include that fix in this PR? |
There was a problem hiding this comment.
@kshehadeh should we have a simple test that verifies that the locale code and alias work - that we get back Ukrainian - just a simple gurka test?
@kshehadeh I think that would fine - or it could be a separate one |
That sounds good. Maybe you can help me wit that? That would be my first :) |
| @@ -18,7 +18,7 @@ | |||
| * FIXED: Fix way_ids -> graph_ids conversion for complex restrictions: handle cases when a way is split into multiple edges [#2848](https://github.com/valhalla/valhalla/pull/2848) | |||
| * FIXED: Honor access mode while matching OSMRestriction with the graph [#2849](https://github.com/valhalla/valhalla/pull/2849) | |||
| * FIXED: Fix compilation errors when boost < 1.68 and libprotobuf < 3.6 [#2878](https://github.com/valhalla/valhalla/pull/2878) | |||
|
|
|||
There was a problem hiding this comment.
can we remove the whitespace?
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?