Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valhalla_export_edges logging interspersed with output #4496

Closed
ianthetechie opened this issue Jan 8, 2024 · 3 comments · Fixed by #4498
Closed

valhalla_export_edges logging interspersed with output #4496

ianthetechie opened this issue Jan 8, 2024 · 3 comments · Fixed by #4498
Labels

Comments

@ianthetechie
Copy link
Contributor

On the current master branch, the expected output from valhalla_export_edges appears to be combined with logs. As far as I can tell, the standard logging facility must be going to stdout, which causes the output to be mixed. It seems the workaround for now is probably to create a new config specifically for exporting edges with mjolnir.logging configured to output to a file.

Long-term fix ideas:

  • I would expect these to go to stderr, but I may be missing some reason why it's useful for these to go to stdout.
  • Alternately, we could have valhalla_export_edges require a file argument to which the contents will be written. I don't know all the history, but the major use case for this command (Pelias) consumes a file on disk.

Thoughts?

@kevinkreiser
Copy link
Member

it's a regression. we did a couple overhauls of all the executables and probably accidentally turned on logging for it when it wasn't on before. just need to patch it up to how it used to be

@kevinkreiser
Copy link
Member

yep accidentally removed the logging to stderr. just need to put it back

@nilsnolde
Copy link
Member

hmpf, my bad.. let me quickly update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants