Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevation Builder Timesout on the Coverage Build #3740

Open
kevinkreiser opened this issue Sep 11, 2022 · 4 comments
Open

Elevation Builder Timesout on the Coverage Build #3740

kevinkreiser opened this issue Sep 11, 2022 · 4 comments

Comments

@kevinkreiser
Copy link
Member

kevinkreiser commented Sep 11, 2022

https://app.circleci.com/pipelines/github/valhalla/valhalla/9433/workflows/ace39ece-eb56-4685-8129-5aae5dd63d49/jobs/54079

The elevation builder test is easily the longest test of all the tests. On CI it takes over 10 minutes during the coverage build and since it doesnt output anything during that time CI bails on it. A quick fix would be to have cmake somehow output a character every so often to work around it but long term it doesnt make sense to test with such a large extract (building all of utrecht again but with elevation this time..). What we should do is:

  1. Convert this test to a gurka test as soon as possible
  2. Fix the bug in get_coord which it assumes it will return an empty set when a tile doesnt exist but actually since it uses the tilebuilder interface (which will not alert you when you try to open an existing tile that doesnt actually exist) it segfaults trying to access graph nodes which arent there (not sure how CI isnt barfing on this already)
@Neyromancer
Copy link
Contributor

i would dive in

@nilsnolde
Copy link
Member

@Neyromancer you still plan to work on this? Else I'll fix it soonish.

@Neyromancer
Copy link
Contributor

@nilsnolde, sure, sorry for delay

@nilsnolde
Copy link
Member

No worries, just checking:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants