-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elevation Builder Timesout on the Coverage Build #3740
Comments
5 tasks
i would dive in |
@Neyromancer you still plan to work on this? Else I'll fix it soonish. |
@nilsnolde, sure, sorry for delay |
No worries, just checking:) |
kevinkreiser
added a commit
that referenced
this issue
Sep 30, 2022
kevinkreiser
added a commit
that referenced
this issue
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://app.circleci.com/pipelines/github/valhalla/valhalla/9433/workflows/ace39ece-eb56-4685-8129-5aae5dd63d49/jobs/54079
The elevation builder test is easily the longest test of all the tests. On CI it takes over 10 minutes during the coverage build and since it doesnt output anything during that time CI bails on it. A quick fix would be to have cmake somehow output a character every so often to work around it but long term it doesnt make sense to test with such a large extract (building all of utrecht again but with elevation this time..). What we should do is:
get_coord
which it assumes it will return an empty set when a tile doesnt exist but actually since it uses the tilebuilder interface (which will not alert you when you try to open an existing tile that doesnt actually exist) it segfaults trying to access graph nodes which arent there (not sure how CI isnt barfing on this already)The text was updated successfully, but these errors were encountered: