Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use custom thread pool for vaadin-dev-server tasks #20795

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

mcollovati
Copy link
Collaborator

Vaadin dev-server executes long-running tasks (e.g. npm install) using the common ForkJoin pool. This can cause a slow startup or even timeouts when the pool size is small.
Using a dedicated executor for dev-server tasks should prevent the above issues.

Fixes #20793

Copy link

github-actions bot commented Dec 31, 2024

Test Results

1 159 files  ± 0  1 159 suites  ±0   1h 28m 10s ⏱️ - 6m 17s
7 579 tests ± 0  7 523 ✅ ± 0  56 💤 ±0  0 ❌ ±0 
7 921 runs   - 20  7 857 ✅  - 18  64 💤  - 2  0 ❌ ±0 

Results for commit 6b5e216. ± Comparison against base commit 041dead.

♻️ This comment has been updated with latest results.

Vaadin dev-server executes long-running tasks (e.g. npm install) using
the common ForkJoin pool. This can cause a slow startup or even timeouts
when the pool size is very small.
Using a dedicated executor for dev-server tasks should prevent the
above issues.

Fixes #20793
@mcollovati mcollovati force-pushed the issues/20793-dev_server_custom_executor branch from 526a00f to 6e02103 Compare December 31, 2024 08:25
Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the patch and works fine in GH actions with pit scripts

@manolo manolo merged commit 68b0fba into main Dec 31, 2024
25 of 26 checks passed
@manolo manolo deleted the issues/20793-dev_server_custom_executor branch December 31, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PiT 24.7: in GH windows runner flow fails when using node installed in the prepare-frontend step
4 participants