Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the compatibility with latest nlohmann-json. #909

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

sighingnow
Copy link
Member

What do these changes do?

as titled.

Related issue number

Fixes #908

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow force-pushed the ht/upgrade-nlohmann-json branch from 7d41edd to 6ffb057 Compare August 11, 2022 10:01
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #909 (6ffb057) into main (6b4cb37) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   70.75%   70.64%   -0.12%     
==========================================
  Files          82       79       -3     
  Lines        8268     8086     -182     
==========================================
- Hits         5850     5712     -138     
+ Misses       2418     2374      -44     
Impacted Files Coverage Δ
src/common/util/protocols.cc 78.79% <50.00%> (-0.32%) ⬇️
src/server/memory/allocator.cc 64.70% <0.00%> (-6.03%) ⬇️
src/client/client_base.cc 90.38% <0.00%> (-0.53%) ⬇️
src/server/async/socket_server.cc 80.63% <0.00%> (-0.21%) ⬇️
src/client/client.cc 68.95% <0.00%> (-0.05%) ⬇️
src/client/client_base.h 87.50% <0.00%> (ø)
src/server/async/socket_server.h 100.00% <0.00%> (ø)
src/server/server/vineyard_server.h 100.00% <0.00%> (ø)
src/server/memory/mimalloc.cc
... and 7 more

@sighingnow sighingnow merged commit 4c27611 into v6d-io:main Aug 11, 2022
@sighingnow sighingnow deleted the ht/upgrade-nlohmann-json branch August 11, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build with latest nlohmann-json
1 participant