Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether the ipc socket exist When parsing the config YAML. #1736

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Check whether the ipc socket exist When parsing the config YAML. #1736

merged 3 commits into from
Jan 29, 2024

Conversation

dashanji
Copy link
Member

What do these changes do?

When using something like client = vineyard.connect(config=./vineyard.yaml), we need to check whether the IPC socket file exists.

@dashanji
Check whether the ipc socket exist When parsing the config YAML.
dd4e523 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji dashanji force-pushed the fix-ipc-socket-not-exist branch from a558d17 to dd4e523 Compare January 29, 2024 05:38
@dashanji
Fix lint error.
8f6caae 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji
Keep the pytest lower than v8.0.0.
f3d85ad 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji dashanji requested a review from sighingnow January 29, 2024 06:53
@dashanji
Copy link
Member Author

The latest pytest(8.0.0) will block something of pytest-cases.
smarie/python-pytest-cases#330

@sighingnow sighingnow merged commit 595e590 into v6d-io:main Jan 29, 2024
5 checks passed
@sighingnow sighingnow deleted the fix-ipc-socket-not-exist branch January 29, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighingnow sighingnow sighingnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dashanji @sighingnow