Reflactor the vineyard scheduler code #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 3c64b3a has been successfully built and deployed to https://deploy-preview-pr-1276--v6d.netlify.app |
dashanji
force-pushed
the
reflactor-scheduler-code
branch
3 times, most recently
from
976d6cc to
327225a
Compare
* Add the RoundRobinStrategy and BestEffortStrategy interface for all vineyard schedulers. * Split the vineyard schedulers into scheduler-on-kubernetes and scheduler-outside-cluster. Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
dashanji
force-pushed
the
reflactor-scheduler-code
branch
2 times, most recently
from
eee07f5 to
227d3ff
Compare
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
dashanji
force-pushed
the
reflactor-scheduler-code
branch
from
227d3ff to
97eb3bd
Compare
sighingnow
approved these changes
Mar 31, 2023
sighingnow
reviewed
Mar 31, 2023
sighingnow
reviewed
Mar 31, 2023
|
All comments addressed. PTAL, thanks. @sighingnow |
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
dashanji
force-pushed
the
reflactor-scheduler-code
branch
from
97fc175 to
bbc85b4
Compare
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled.
Related issue number
Fixes some parts of #1234