Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CasesContext #241

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Implement CasesContext #241

merged 1 commit into from
Feb 23, 2024

Conversation

JennyVong
Copy link
Contributor

@JennyVong JennyVong commented Feb 11, 2024

Notion ticket link

Implement CasesContext

Implementation description

  • In HomePage replace useState for CaseCardProps and use CasesContext instead

Steps to test

  1. everything should still look the same on homepage, props are a little easier to manage

What should reviewers focus on?

  • view all case page and filterCaseDisplay still uses caseCardProps - don't know if you'd prefer that to be changed as well
  • cases also display the correct referralDate and familyName

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

Visit the preview URL for this PR (updated for commit f7043ca):

https://childrens-aid-society--pr241-jenny-cases-context-liikr9kh.web.app

(expires Sun, 18 Feb 2024 01:04:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93f6cb7bff946a1edd29d684408e6d31442cf0b1

Copy link
Contributor

@vaaranan-y vaaranan-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JennyVong JennyVong merged commit 52e0165 into main Feb 23, 2024
7 checks passed
@JennyVong JennyVong deleted the jenny/cases-context branch February 23, 2024 05:39
helioshe4 pushed a commit that referenced this pull request Mar 17, 2024
home page cases context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants