Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Visit REST Endpoints (POST) #240

Merged
merged 17 commits into from
May 17, 2024
Merged

Conversation

JoshuaYe
Copy link
Contributor

Notion ticket link

Implement Visit REST Endpoints (POST)

Implementation description

  • Create_visit() endpoint in visit.py
  • Update get_visits() to populate "attendance" and "transportation" fields in visit object
  • This ticket is incomplete. Next steps:
  1. Create Transportation and VisitingMember services (similar to AttendanceRecordService)
  2. Call the services in get_visits() to populate "attendance" and "transportation" fields in visit object
  3. In the attendance_record object of create_visit(), ensure the "attendance" and "attending_family" fields are dynamic not hard-coded
  4. Test get_visits() to ensure all data is included in visit object
  5. Test create_visit() to ensure all data is inserted into the DB

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@JoshuaYe JoshuaYe requested a review from Ezzhingy December 22, 2023 19:15
Copy link
Contributor

@vaaranan-y vaaranan-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaaranan-y vaaranan-y merged commit e80d4c0 into main May 17, 2024
5 checks passed
@vaaranan-y vaaranan-y deleted the josh/visits-post_visit_endpoint branch May 17, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants