Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface descriptions & Fix Wordings #220

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Conversation

Ezzhingy
Copy link
Collaborator

@Ezzhingy Ezzhingy commented Nov 4, 2023

Implementation description

  • Added some interface function method descriptions
  • Fixed attendance sheet interface typos

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Ezzhingy Ezzhingy merged commit 5b89bbf into main Nov 5, 2023
5 checks passed
@Ezzhingy Ezzhingy deleted the eugene/chore-wording branch November 5, 2023 00:01
odis43 pushed a commit that referenced this pull request Nov 23, 2023
* Fix sheet funciton name

* Sheet interface chore

* Sheet & Behavior chore
odis43 pushed a commit that referenced this pull request Nov 23, 2023
* Fix sheet funciton name

* Sheet interface chore

* Sheet & Behavior chore
odis43 added a commit that referenced this pull request Nov 29, 2023
* visit.py for DELETE CRUD function

* delete_visit implementation

* delete_visit bug fixed

* spelling error fix (attendace to attendance)

* initial commit

* initial

* visit put endpoint implemented

* added attendance_record_service.py interface

* Update attendance sheet fields (#208)

* finalized attendance sheet field changes

* Perform linting

* Remove month field from attendance sheet DTO

* fixed linting

---------

Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>

* Implement get by intake_id for all services relating to intake (#209)

* get caregiver by id works

* fix intake id

* add caregiver itnerface

* add child service works, and appending to intake works

* get opi by intake id working

* fix caregiver method

* make caregiver like jenny's

* get children working

* refactored get children

* providers work

* fix caregivers

* opi works

* add column to daytime_contacts and add goals to intake

* daytime contacts working

* add interface

* run linter

* fix goals and tests

* Update seed for better testing

* made changes based on review

* revert changes to program details

---------

Co-authored-by: Eugene Zhang <zhang.eug@gmail.com>

* fix program detail values and review form (#205)

* fix program detail values and review form

* remove log

* fix positioning of icons in program intake form

---------

Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>

* Merge db heads (#213)

* Implement visit component skeleton (#202)

* Implement visit component skeleton

* fix linting

* Fix small comments

* fix linting issue

* Wrapped exit arrow with button

* lint

* Kevin y/implement attendance record service (#210)

* Created attendance sheet service, routes (in visit.py), and test

* Fixed test b/c attendance sheet got updated

* Fix edit caregiver to delete logic (#215)

* Fit Intake Cases (#212)

modified position, padding, and case width

* Refactor case over routing to display proper case data (#214)

* Add dynamic routing and data read on case overview

* fix linting

* change data saving for caseLead

---------

Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>

* Implement Visit REST Endpoints (GET) (#211)

* Create visit.py

* Run linter and instantiate visit.py

* Implement GET visits endpoints

* Stylistic changes

* Run linter

* Make requested changes

* Add interface descriptions & Fix Wordings (#220)

* Fix sheet funciton name

* Sheet interface chore

* Sheet & Behavior chore

* Fill in Additional Fields and Restructuring Object for GET Intake  (#217)

* got transportRequirements, schedulingRequirements, and suggestedStartDate working

* everything working except child behaviour

* make concerns work

* run linter

* implement PR changes

* implemented pr changes pt 2

* lint code'

* load cases in view all cases page (#219)

* Fix: Replace lead with referringWorker (#223)

Replace lead with worker

* visit.py for DELETE CRUD function

* delete_visit bug fixed

* spelling error fix (attendace to attendance)

* initial commit

* initial

* visit put endpoint implemented

* pr changes

* linting backend

---------

Co-authored-by: Omer Adeel <57784751+omeradeel26@users.noreply.github.com>
Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>
Co-authored-by: Jacqueline Fung <fungjsl@gmail.com>
Co-authored-by: Eugene Zhang <zhang.eug@gmail.com>
Co-authored-by: Bowen Zhu <43287170+bowenzhu1@users.noreply.github.com>
Co-authored-by: Eugene Zhang <86681988+Ezzhingy@users.noreply.github.com>
Co-authored-by: Kevin Yan <70108329+kevinasian122@users.noreply.github.com>
Co-authored-by: Cindy Li <82128464+cindyhjli@users.noreply.github.com>
Co-authored-by: JoshuaYe <joshua.ye@live.com>
Co-authored-by: Jenny Vong <jenny_vong@outlook.com>
jacque1ine added a commit that referenced this pull request Dec 11, 2023
* visit.py for DELETE CRUD function

* delete_visit implementation

* delete_visit bug fixed

* spelling error fix (attendace to attendance)

* initial commit

* initial

* visit put endpoint implemented

* added attendance_record_service.py interface

* Update attendance sheet fields (#208)

* finalized attendance sheet field changes

* Perform linting

* Remove month field from attendance sheet DTO

* fixed linting

---------

Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>

* Implement get by intake_id for all services relating to intake (#209)

* get caregiver by id works

* fix intake id

* add caregiver itnerface

* add child service works, and appending to intake works

* get opi by intake id working

* fix caregiver method

* make caregiver like jenny's

* get children working

* refactored get children

* providers work

* fix caregivers

* opi works

* add column to daytime_contacts and add goals to intake

* daytime contacts working

* add interface

* run linter

* fix goals and tests

* Update seed for better testing

* made changes based on review

* revert changes to program details

---------

Co-authored-by: Eugene Zhang <zhang.eug@gmail.com>

* fix program detail values and review form (#205)

* fix program detail values and review form

* remove log

* fix positioning of icons in program intake form

---------

Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>

* Merge db heads (#213)

* Implement visit component skeleton (#202)

* Implement visit component skeleton

* fix linting

* Fix small comments

* fix linting issue

* Wrapped exit arrow with button

* lint

* Kevin y/implement attendance record service (#210)

* Created attendance sheet service, routes (in visit.py), and test

* Fixed test b/c attendance sheet got updated

* Fix edit caregiver to delete logic (#215)

* Fit Intake Cases (#212)

modified position, padding, and case width

* Refactor case over routing to display proper case data (#214)

* Add dynamic routing and data read on case overview

* fix linting

* change data saving for caseLead

---------

Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>

* Implement Visit REST Endpoints (GET) (#211)

* Create visit.py

* Run linter and instantiate visit.py

* Implement GET visits endpoints

* Stylistic changes

* Run linter

* Make requested changes

* Add interface descriptions & Fix Wordings (#220)

* Fix sheet funciton name

* Sheet interface chore

* Sheet & Behavior chore

* Fill in Additional Fields and Restructuring Object for GET Intake  (#217)

* got transportRequirements, schedulingRequirements, and suggestedStartDate working

* everything working except child behaviour

* make concerns work

* run linter

* implement PR changes

* implemented pr changes pt 2

* lint code'

* load cases in view all cases page (#219)

* Fix: Replace lead with referringWorker (#223)

Replace lead with worker

* visit.py for DELETE CRUD function

* delete_visit bug fixed

* spelling error fix (attendace to attendance)

* initial commit

* initial

* visit put endpoint implemented

* pr changes

* linting backend

---------

Co-authored-by: Omer Adeel <57784751+omeradeel26@users.noreply.github.com>
Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>
Co-authored-by: Jacqueline Fung <fungjsl@gmail.com>
Co-authored-by: Eugene Zhang <zhang.eug@gmail.com>
Co-authored-by: Bowen Zhu <43287170+bowenzhu1@users.noreply.github.com>
Co-authored-by: Eugene Zhang <86681988+Ezzhingy@users.noreply.github.com>
Co-authored-by: Kevin Yan <70108329+kevinasian122@users.noreply.github.com>
Co-authored-by: Cindy Li <82128464+cindyhjli@users.noreply.github.com>
Co-authored-by: JoshuaYe <joshua.ye@live.com>
Co-authored-by: Jenny Vong <jenny_vong@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant