Implement get by intake_id for all services relating to intake #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ezzhingy
requested changes
Oct 8, 2023
There was a problem hiding this comment.
hm im getting an err when trying to upgrade the db—it seems that multiple heads r present when u made some migrations
could u try merging the heads by running docker exec -it cas_py_backend /bin/bash -c "flask db merge heads -m "merging two heads""? lmk if this doesn't work
Ezzhingy
requested changes
Oct 8, 2023
| "longTermGoals": goal_service.get_goal_names_by_intake( | ||
| intake.id, "LONG_TERM" | ||
| ), | ||
| "familialConcerns": ["concern1", "concern2"], |
There was a problem hiding this comment.
i think its ok to leave this as an empty array
Comment on lines
+129
to
+131
| "transportRequirements": "", | ||
| "schedulingRequirements": "", | ||
| "suggestedStartDate": "", |
There was a problem hiding this comment.
substitute lines ~177-183 into this to fill these in
"transportation_requirements": request.json["programDetails"][
"transportRequirements"
],
"scheduling_requirements": request.json["programDetails"][
"schedulingRequirements"
],
"suggested_start_date": request.json["programDetails"]["suggestedStartDate"],
| "cpinFileNumber": child.cpin_number, | ||
| "serviceWorker": child.service_worker, | ||
| "specialNeeds": child.special_needs, | ||
| "concerns": [], |
There was a problem hiding this comment.
im gonna ask bowen abt the struct of the Child class/DTO, cuz it doesn't rly make sense to have this as an empty arr—i'll get back to u on this
odis43
pushed a commit
that referenced
this pull request
Nov 23, 2023
* get caregiver by id works * fix intake id * add caregiver itnerface * add child service works, and appending to intake works * get opi by intake id working * fix caregiver method * make caregiver like jenny's * get children working * refactored get children * providers work * fix caregivers * opi works * add column to daytime_contacts and add goals to intake * daytime contacts working * add interface * run linter * fix goals and tests * Update seed for better testing * made changes based on review * revert changes to program details --------- Co-authored-by: Eugene Zhang <zhang.eug@gmail.com>
odis43
pushed a commit
that referenced
this pull request
Nov 23, 2023
* get caregiver by id works * fix intake id * add caregiver itnerface * add child service works, and appending to intake works * get opi by intake id working * fix caregiver method * make caregiver like jenny's * get children working * refactored get children * providers work * fix caregivers * opi works * add column to daytime_contacts and add goals to intake * daytime contacts working * add interface * run linter * fix goals and tests * Update seed for better testing * made changes based on review * revert changes to program details --------- Co-authored-by: Eugene Zhang <zhang.eug@gmail.com>
odis43
added a commit
that referenced
this pull request
Nov 29, 2023
* visit.py for DELETE CRUD function * delete_visit implementation * delete_visit bug fixed * spelling error fix (attendace to attendance) * initial commit * initial * visit put endpoint implemented * added attendance_record_service.py interface * Update attendance sheet fields (#208) * finalized attendance sheet field changes * Perform linting * Remove month field from attendance sheet DTO * fixed linting --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> * Implement get by intake_id for all services relating to intake (#209) * get caregiver by id works * fix intake id * add caregiver itnerface * add child service works, and appending to intake works * get opi by intake id working * fix caregiver method * make caregiver like jenny's * get children working * refactored get children * providers work * fix caregivers * opi works * add column to daytime_contacts and add goals to intake * daytime contacts working * add interface * run linter * fix goals and tests * Update seed for better testing * made changes based on review * revert changes to program details --------- Co-authored-by: Eugene Zhang <zhang.eug@gmail.com> * fix program detail values and review form (#205) * fix program detail values and review form * remove log * fix positioning of icons in program intake form --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> * Merge db heads (#213) * Implement visit component skeleton (#202) * Implement visit component skeleton * fix linting * Fix small comments * fix linting issue * Wrapped exit arrow with button * lint * Kevin y/implement attendance record service (#210) * Created attendance sheet service, routes (in visit.py), and test * Fixed test b/c attendance sheet got updated * Fix edit caregiver to delete logic (#215) * Fit Intake Cases (#212) modified position, padding, and case width * Refactor case over routing to display proper case data (#214) * Add dynamic routing and data read on case overview * fix linting * change data saving for caseLead --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> * Implement Visit REST Endpoints (GET) (#211) * Create visit.py * Run linter and instantiate visit.py * Implement GET visits endpoints * Stylistic changes * Run linter * Make requested changes * Add interface descriptions & Fix Wordings (#220) * Fix sheet funciton name * Sheet interface chore * Sheet & Behavior chore * Fill in Additional Fields and Restructuring Object for GET Intake (#217) * got transportRequirements, schedulingRequirements, and suggestedStartDate working * everything working except child behaviour * make concerns work * run linter * implement PR changes * implemented pr changes pt 2 * lint code' * load cases in view all cases page (#219) * Fix: Replace lead with referringWorker (#223) Replace lead with worker * visit.py for DELETE CRUD function * delete_visit bug fixed * spelling error fix (attendace to attendance) * initial commit * initial * visit put endpoint implemented * pr changes * linting backend --------- Co-authored-by: Omer Adeel <57784751+omeradeel26@users.noreply.github.com> Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> Co-authored-by: Jacqueline Fung <fungjsl@gmail.com> Co-authored-by: Eugene Zhang <zhang.eug@gmail.com> Co-authored-by: Bowen Zhu <43287170+bowenzhu1@users.noreply.github.com> Co-authored-by: Eugene Zhang <86681988+Ezzhingy@users.noreply.github.com> Co-authored-by: Kevin Yan <70108329+kevinasian122@users.noreply.github.com> Co-authored-by: Cindy Li <82128464+cindyhjli@users.noreply.github.com> Co-authored-by: JoshuaYe <joshua.ye@live.com> Co-authored-by: Jenny Vong <jenny_vong@outlook.com>
jacque1ine
added a commit
that referenced
this pull request
Dec 11, 2023
* visit.py for DELETE CRUD function * delete_visit implementation * delete_visit bug fixed * spelling error fix (attendace to attendance) * initial commit * initial * visit put endpoint implemented * added attendance_record_service.py interface * Update attendance sheet fields (#208) * finalized attendance sheet field changes * Perform linting * Remove month field from attendance sheet DTO * fixed linting --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> * Implement get by intake_id for all services relating to intake (#209) * get caregiver by id works * fix intake id * add caregiver itnerface * add child service works, and appending to intake works * get opi by intake id working * fix caregiver method * make caregiver like jenny's * get children working * refactored get children * providers work * fix caregivers * opi works * add column to daytime_contacts and add goals to intake * daytime contacts working * add interface * run linter * fix goals and tests * Update seed for better testing * made changes based on review * revert changes to program details --------- Co-authored-by: Eugene Zhang <zhang.eug@gmail.com> * fix program detail values and review form (#205) * fix program detail values and review form * remove log * fix positioning of icons in program intake form --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> * Merge db heads (#213) * Implement visit component skeleton (#202) * Implement visit component skeleton * fix linting * Fix small comments * fix linting issue * Wrapped exit arrow with button * lint * Kevin y/implement attendance record service (#210) * Created attendance sheet service, routes (in visit.py), and test * Fixed test b/c attendance sheet got updated * Fix edit caregiver to delete logic (#215) * Fit Intake Cases (#212) modified position, padding, and case width * Refactor case over routing to display proper case data (#214) * Add dynamic routing and data read on case overview * fix linting * change data saving for caseLead --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> * Implement Visit REST Endpoints (GET) (#211) * Create visit.py * Run linter and instantiate visit.py * Implement GET visits endpoints * Stylistic changes * Run linter * Make requested changes * Add interface descriptions & Fix Wordings (#220) * Fix sheet funciton name * Sheet interface chore * Sheet & Behavior chore * Fill in Additional Fields and Restructuring Object for GET Intake (#217) * got transportRequirements, schedulingRequirements, and suggestedStartDate working * everything working except child behaviour * make concerns work * run linter * implement PR changes * implemented pr changes pt 2 * lint code' * load cases in view all cases page (#219) * Fix: Replace lead with referringWorker (#223) Replace lead with worker * visit.py for DELETE CRUD function * delete_visit bug fixed * spelling error fix (attendace to attendance) * initial commit * initial * visit put endpoint implemented * pr changes * linting backend --------- Co-authored-by: Omer Adeel <57784751+omeradeel26@users.noreply.github.com> Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> Co-authored-by: Jacqueline Fung <fungjsl@gmail.com> Co-authored-by: Eugene Zhang <zhang.eug@gmail.com> Co-authored-by: Bowen Zhu <43287170+bowenzhu1@users.noreply.github.com> Co-authored-by: Eugene Zhang <86681988+Ezzhingy@users.noreply.github.com> Co-authored-by: Kevin Yan <70108329+kevinasian122@users.noreply.github.com> Co-authored-by: Cindy Li <82128464+cindyhjli@users.noreply.github.com> Co-authored-by: JoshuaYe <joshua.ye@live.com> Co-authored-by: Jenny Vong <jenny_vong@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Implement get by intake_id for all services relating to intake
Implementation description
Steps to test
What should reviewers focus on?
Checklist