Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for cache and fixes env var format #2945

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Nov 26, 2021

As requested for cache persistence, this adds some basic testing for image caching.

Further, writing the test showed that the formatting of the build-arg was wrong, so this PR fixes that too.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

Sorry, something went wrong.

@bomoko bomoko requested a review from tobybellwood November 26, 2021 03:27
@tobybellwood
Copy link
Member

two quick fixups to get this testing:

  • merge main branch in, then update make docker_pull in the makefile to also exclude _CACHE in grep -Ev '_REPO|_VERSION|_CACHE'
  • add image-cache to the TESTS var in the jenkinsfile second test-sute

@bomoko
Copy link
Contributor Author

bomoko commented Nov 28, 2021

Done @tobybellwood

@tobybellwood tobybellwood merged commit 1d45edf into uselagoon:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants