Scale idled environments up if SSH connections are made #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nection is made to an environment
Schnitzel
requested changes
Mar 25, 2021
services/ssh/home/rsh.sh
Outdated
Comment on lines
143
to
152
| # for unidling an entire environment and waiting for the number of `readyReplicas` | ||
| # to be 1 for each deployment, could add considerable delays for the ssh connection to establish. | ||
| # WAIT_TO_UNIDLE_SERVICES will default to false so that it just scales the deployments | ||
| # and won't wait for them to be ready, but if set to true, it will wait for `readyReplicas` to be 1 | ||
| if [[ "$WAIT_TO_UNIDLE_SERVICES" =~ [Tt][Rr][Uu][Ee] ]]; then | ||
| while [[ ! $($OC get ${DEP} -o go-template --template='{{.status.readyReplicas}}') == "1" ]] | ||
| do | ||
| sleep 1 | ||
| done | ||
| fi |
There was a problem hiding this comment.
I would suggest two changes:
- can we split the actual unidling and the waiting into two for loops? In this case we first trigger scaling of all deployments and then maybe wait for them to be available, which would probably reduce the time that we need to wait.
- if a deployment had 2 replicas, the
--template='{{.status.readyReplicas}}') == "1"will fail, I think we should just check that is has 1 or more replicas.
There was a problem hiding this comment.
On 1) waiting for all services in the environment to become available could add considerable delays to establishing the ssh connection though. Which is why I did it the way I did, where it unidles them but won't wait for them to become ready (unless the WAIT_TO_UNIDLE_SERVICES var is set to true, which defaults to false)
I'll fix the 1+ replica check now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
With the introduction of idling to Kubernetes clusters, sometimes if an environment is idled, the user may experience an issue trying to run commands in the requested service if other services are idled.
This adds a step to the SSH connection request that will scale any idled services up. It does this before the requested service is loaded and aims to help reduce this issue.